Skip to content

fix(chat): fix interrupt not working#55

Merged
0xmrpeter merged 1 commit into
Open-ACP:developfrom
lngdao:develop
Apr 20, 2026
Merged

fix(chat): fix interrupt not working#55
0xmrpeter merged 1 commit into
Open-ACP:developfrom
lngdao:develop

Conversation

@lngdao

@lngdao lngdao commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Root cause: cancelPrompt was calling POST /sessions/:id/cancel which returns 404 — correct route is POST /sse/sessions/:id/cancel
  • Abort guard changed from single global ref to per-session Map for multi-session support
  • abort() is now async — instant mode awaits server acknowledgement before sending new prompt
  • Interrupted flag preserved across session switches via position-based merge in loadHistory
  • Reduced abort guard fallback timeout from 30s to 10s
  • Updated tauri-plugin-fs Cargo.lock to match NPM version (2.5.0)

Test plan

  • Interrupt a streaming message → verify it stops immediately
  • Switch session and switch back → verify interrupted label persists
  • Interrupt in instant mode → verify new message processes correctly
  • Verify CI builds pass (tauri-plugin-fs version mismatch resolved)

… guard improvements

- Fix cancelPrompt URL: /sessions/:id/cancel → /sse/sessions/:id/cancel (was 404)
- Make abort() async, await server acknowledgement before sending new prompt in instant mode
- Change abortedTurnId from single ref to per-session Map to support multi-session abort
- Add double-fire guard to prevent aborting same session twice
- Preserve interrupted flag across session switches in loadHistory (position-based merge)
- Reduce abort guard fallback timeout from 30s to 10s
- Update tauri-plugin-fs to match NPM version (2.4.5 → 2.5.0)
@0xmrpeter 0xmrpeter merged commit e533e50 into Open-ACP:develop Apr 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants