fix: Typing Rate Limit in ActivityTracker#14
Draft
kevin-david wants to merge 2 commits into
Draft
Conversation
kevin-david
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a race condition in
ActivityTracker.startTyping()where rapid thought events could trigger concurrentsendTypingcalls before the refresh interval was set. This led to multiple duplicate timers and Discord API rate limiting.Added a synchronous
typingActiveguard flag to ensure only onesendTypingrequest is in flight at a time.Caveat
This issue is currently being reproduced via a resume bug in the Gemini agent which emits rapid catch-up events. However, this fix provides general stability against any rapid sequence of thought events.
Regression Test
Added a test case in
activity.test.tsthat simulates concurrentonThoughtcalls and verifies that only one API call is made and only one interval is spawned. Fails pre-changes.Manual Testing
Gemini resume doesn't create a neverending typing indicator anymore!