feat: respect configured output verbosity; quiet medium by default#6
Merged
Conversation
The verbosity mode setting was effectively dead before — the discord adapter's sendMessage override called super.sendMessage(), which resolves verbosity via the base class's channel-config lookup. That lookup doesn't see the discord plugin's settings-backed outputMode and silently fell back to 'medium'. As a result, neither 'low' nor 'high' had any runtime effect. Routing fix - sendMessage now dispatches via this.resolveMode(sessionId), which reads the discord plugin settings (and per-session override). Behavior at medium / high - Usage embeds and the cross-channel Task-completed ping were firing at every prompt's end. Most users find that noisy at the default tier. They're now gated to 'high' only — opt-in via explicit verbosity for users who want the metrics. - Medium continues to show thinking text, full tool cards, and per-prompt activity — just without the receipts. | Mode | Thinking text | Tool cards | Usage embed | Task-completed | |---------|---------------|--------------|-------------|----------------| | low | hidden* | compact* | hidden | hidden | | medium | shown | full | hidden (NEW)| hidden (NEW) | | high | shown | full + extra | shown | shown | * Low has the pre-existing draft-finalization bug (text never finalizes because handleUsage isn't called when usage events are filtered by HIDDEN_ON_LOW). Out of scope for this PR — happy to address separately if anyone wants low to be a viable tier. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
There's still some weirdness here, at least with gemini - prior messages being edited. Marking as draft for now |
Contributor
Author
|
Tuns out that was a different issue and this should be fine! More PRs coming... |
Contributor
|
Thanks for tracking this down! The routing change from A couple of minor notes for follow-up:
Overall a clean and necessary fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The verbosity mode setting was effectively dead before — the discord adapter's
sendMessageoverride calledsuper.sendMessage(), which resolves verbosity via the base class's channel-config lookup. That lookup doesn't see the discord plugin's settings-backedoutputModeand silently fell back tomedium. As a result, neitherlownorhighhad any runtime effect.What changes
Routing fix —
sendMessagenow dispatches viathis.resolveMode(sessionId), which reads the discord plugin settings (and per-session override).Medium becomes quieter — usage embeds and the cross-channel Task-completed ping were firing at every prompt's end. Most users find that noisy at the default tier. They're now gated to
highonly — opt-in via explicit verbosity for users who want the metrics.* Low has a pre-existing draft-finalization bug (text never finalizes because
handleUsageisn't called whenusageevents are filtered upstream byHIDDEN_ON_LOW). Out of scope for this PR — happy to address separately if anyone wantslowto be a viable tier.Test plan
outputMode: "high"→ confirm usage embed and Task-completed fire at end of each promptoutputMode: "medium"→ confirm thinking text + tool cards still render but no usage embed / Task-completed🤖 Generated with Claude Code