feat(slack): parity phase 3 — 4 more gaps closed#14
Merged
Conversation
Matches Telegram pattern at adapter.ts:1572. Without this guard, large files fail opaquely inside files.uploadV2 — the user sees nothing and the agent doesn't know the file never arrived. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…hrowing Before: start() threw 'Slack adapter requires botToken, appToken, and signingSecret' — which cascades up and brings the whole OpenACP host down even though the user only wanted Slack disabled. Now: - start() logs a warning naming the missing field(s) and returns early - stop() guards against this.app being undefined (graceful-degrade path) - index.ts setup gate now also checks signingSecret to short-circuit before constructing the adapter Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
In-memory _skillCommandsTs was lost on restart, causing sendSkillCommands to post a duplicate card instead of updating the original. Now hydrate from platform.skillMsgTs on first call after restart, and persist back to the session record when a new card is posted. Mirrors Telegram's SkillCommandManager pattern at telegram/skill-command-manager.ts:43-46, 94-98. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…notice
Telegram updates its pinned control card when model/mode/bypass changes.
Without a control card in Slack, posting a brief inline notice
('⚙️ Session settings updated — model: `X`, mode: `Y`, bypass: on')
at least surfaces the change to users who aren't reading log output.
Listener registered in start(), torn down in stop().
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
If the user deletes the skill commands card, chat.update fails with message_not_found and the cached ts becomes a permanent error loop. Now we delete the cached ts on failure so the next sendSkillCommands call posts a fresh card. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened PR (original #12 closed when base deleted).
Closed gaps
Bumps to 2026.525.3. 117 tests pass.