This repository was archived by the owner on Oct 1, 2025. It is now read-only.
fix: signature used for direct signing is unchecked#105
Closed
yehjxraymond wants to merge 1 commit intomasterfrom
Closed
fix: signature used for direct signing is unchecked#105yehjxraymond wants to merge 1 commit intomasterfrom
yehjxraymond wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Severity: Info
Signature used for direct signing is unchecked
Independently, this issue does not make any documents vulnerable. Once it is chained with the upcoming PR #93, an adversary can issue document from a legitimate organisation using their domain when it adds in a valid signature from an unknown address and reusing the
documentStoreandDNS-TXTfrom the legitimate organisation in the document.