Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

chroe: move snyk to devDep#185

Open
eugbyte wants to merge 2 commits intomasterfrom
fix/move-snyk-to-devDep
Open

chroe: move snyk to devDep#185
eugbyte wants to merge 2 commits intomasterfrom
fix/move-snyk-to-devDep

Conversation

@eugbyte
Copy link
Contributor

@eugbyte eugbyte commented Jul 21, 2021

Right now, snyk is added as a direct dependency. This increases the size of the oa-verify library by at least 20mb.

An implication, for example, is that the aws lambda is preventing me from uploading my function (which depends on oa-verify) due to the size limit.

I moved snyk dependency to a devDepency.

To test

npm i
npm run snyk-protect

@eugbyte eugbyte requested a review from Nebulis July 21, 2021 15:19
@Nebulis
Copy link
Contributor

Nebulis commented Jul 22, 2021

image

Looks like it's required in order to run snyk protect. Let's try to use tree shaking instead => https://webpack.js.org/guides/tree-shaking/

Please show the bundle before and after applying tree shaking https://www.npmjs.com/package/webpack-bundle-analyzer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants