feat: 🎸 Add verifier for w3c-did identityProof#80
feat: 🎸 Add verifier for w3c-did identityProof#80AdamJLemmon wants to merge 3 commits intoOpen-Attestation:masterfrom
Conversation
AdamJLemmon
commented
Jan 9, 2020
AdamJLemmon
commented
- Support for universal resolver for broad did resolution.
- Initial did-auth support for ethr did-method utilizing comparison against tx.origin of document issuance tx.
Support for universal resolver for broad did resolution. Initial did-auth support for ethr did-method utilizing comparison against tx.origin of document issuance tx.
| smartContract: string; | ||
| } | ||
|
|
||
| export interface DIDDocument { |
There was a problem hiding this comment.
I think you can use some of the types/methods from here https://github.com/decentralized-identity/did-common-typescript/blob/master/lib/IDidDocument.ts
There was a problem hiding this comment.
I actually pulled direct from the did-resolver here: https://github.com/decentralized-identity/did-resolver/blob/02bdaf1687151bb934b10093042e576ed54b229c/src/resolver.ts#L15
There was a problem hiding this comment.
would it make sense to then install it as a dependency and use the exported types?
There was a problem hiding this comment.
That feels like a good solution. Then also as types inevitably evolve we can just bump version of the package instead of having to replicate changes manually... I like it.
| status: "SKIPPED", | ||
| type, | ||
| name, | ||
| message: `Document issuer doesn't doesn't use ${v3.IdentityProofType.W3CDid} type` |
| "@govtechsg/open-attestation": "3.1.0", | ||
| "@types/request-promise-native": "^1.0.17", | ||
| "ethers": "^4.0.40", | ||
| "request-promise-native": "^1.0.8" |
There was a problem hiding this comment.
we usually use axios with async/await
2 participants
