Skip to content

feat: productize Windows external-edit learning 还没好#431

Closed
Cooper-X-Oak wants to merge 5 commits into
Open-Less:betafrom
Cooper-X-Oak:feat/external-edit-productization
Closed

feat: productize Windows external-edit learning 还没好#431
Cooper-X-Oak wants to merge 5 commits into
Open-Less:betafrom
Cooper-X-Oak:feat/external-edit-productization

Conversation

@Cooper-X-Oak

Copy link
Copy Markdown
Contributor

Summary

  • productize Windows external-edit auto learning on the formal OpenLess dictation path instead of the lab/debug path
  • arm a short-lived Windows observer after successful insertion, persist learned old -> new replacements into formal correction-rules.json, and deterministically reuse them on later dictation
  • document the first-batch Windows support matrix and add reproducible smoke / observer verification scripts

What changed

  • add windows_external_edit.rs and wire it into the formal coordinator dictation lifecycle
  • reuse formal correction rules as v1 terminology memory, including wrapped-array compatibility for correction-rules.json
  • add minimal Settings toggle / IPC / i18n surface for Windows external-edit auto learning
  • harden Windows smoke verification for Notepad and Edge, including Edge guest-mode fixture flow and UIA-based readback / observer verification
  • update the Windows productization doc with support boundaries, evidence, expected-vs-actual debugging notes, and runbook

First-batch support boundary

  • Supported with current worktree evidence: Windows Notepad, Microsoft Edge textarea
  • Historically supported but not freshly re-evidenced in this worktree: WeChat input box
  • Not supported: Zed, Windows Terminal
  • Unverified: VS Code

Validation

  • npm run build
  • cargo build --manifest-path openless-all/app/src-tauri/Cargo.toml --target-dir D:\cargo-targets\openless-extedit --bin openless
  • Notepad formal insertion / observer / rewrite-hit smoke
  • Edge formal insertion / observer / rewrite-hit smoke
  • Note: Rust test harness still fails to execute on this machine with STATUS_ENTRYPOINT_NOT_FOUND, so real smoke/log/rule-file evidence was used for this PR

Draft status

This PR should stay draft until:

  • CI on beta passes
  • human validation passes on the supported Windows targets

appergb and others added 5 commits May 7, 2026 22:02
…ss#333)

release-sync: workflow rollout + soaked beta features → main
PR Open-Less#330 在 jobs.build 顶层多加了一个 env: 块来定义 OPENLESS_RELEASE_CHANNEL,
但下面 strategy/runs-on 之后已经有一个 env: 块(TAURI_SIGNING_PRIVATE_KEY 等)。
YAML map 不允许重复 key——GitHub Actions 解析直接 fail,整条 release-tauri.yml
工作流变成 "workflow file issue" 启动失败。

修复:把 OPENLESS_RELEASE_CHANNEL 并到下面那个唯一的 env: 块里,保留完整注释。

校验:
- python -c "yaml.safe_load(...)" 解析成功
- jobs.build.env 现在有 3 个 key: OPENLESS_RELEASE_CHANNEL, TAURI_SIGNING_PRIVATE_KEY,
  TAURI_SIGNING_PRIVATE_KEY_PASSWORD

Co-authored-by: baiqing <lbx12309@icloud.com>
@Cooper-X-Oak Cooper-X-Oak changed the title feat: productize Windows external-edit learning feat: productize Windows external-edit learning 还没好 May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants