Skip to content

fix(settings): 设置弹窗用 Portal 渲染避免被页面滚动条覆盖 (#580) #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
H-Chris233 merged 1 commit into from
Jun 9, 2026
Merged

fix(settings): 设置弹窗用 Portal 渲染避免被页面滚动条覆盖 (#580) #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions openless-all/app/src/components/SettingsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// 不在此弹窗出现。

import { useLayoutEffect, useRef, useState } from 'react';
import { createPortal } from 'react-dom';
import { useTranslation } from 'react-i18next';
import { Icon } from './Icon';
import { SavedToast } from './SavedToast';
Expand Down Expand Up @@ -69,11 +70,15 @@ export function SettingsModal({ os: _os, onClose, initialSettingsSection }: Sett
setPillRect({ top: el.offsetTop, height: el.offsetHeight });
}, [section]);

return (
// issue #580：用 Portal 渲染到 document.body，脱离页面 overflow:hidden 容器的
// stacking context。否则 WebKitGTK（Debian/KDE Wayland）下页面自绘滚动条
// (.ol-thinscroll) 不创建独立合成层，z-index 无法隔离，滚动时会盖在弹窗之上。
// 配合 position:fixed 覆盖整窗。
return createPortal(
<div
onClick={onClose}
style={{
position: 'absolute', inset: 0,
position: 'fixed', inset: 0,
background: 'rgba(15,17,22,0.32)',
backdropFilter: 'blur(8px) saturate(140%)',
WebkitBackdropFilter: 'blur(8px) saturate(140%)',
Expand Down Expand Up @@ -205,7 +210,8 @@ export function SettingsModal({ os: _os, onClose, initialSettingsSection }: Sett
</div>
</div>
</div>
</div>
</div>,
document.body,
);
}

Expand Down
Loading