feat(windows): WebView2 lazy webviews + Android auto-update + history repolish#694
Closed
HKLHaoBin wants to merge 13 commits into
Closed
feat(windows): WebView2 lazy webviews + Android auto-update + history repolish#694HKLHaoBin wants to merge 13 commits into
HKLHaoBin wants to merge 13 commits into
Conversation
Align updateChannel prefs with background AutoUpdateGate, add symmetric manual stable/beta check buttons, Android auto-download after check, and settings toggle; extract updater_logic helpers with unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
call_static_method caused NoSuchMethodError on Thread-8 during AutoUpdateGate background check, killing the app ~4s after launch. Co-authored-by: Cursor <cursoragent@cursor.com>
Manual workflow_dispatch builds signed release APKs when ANDROID_KEYSTORE_* is configured (overlay install, data preserved); otherwise falls back to unsigned debug with job summary notice. Tag releases still require all secrets; minisign/manifest/GitHub Release remain tag-only. Co-authored-by: Cursor <cursoragent@cursor.com>
Sync UPDATER_PUBKEY_B64 with tauri.conf.json; fail download when installApk returns false; put Beta channel above auto-update toggle; add pubkey CI check script. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid squeezing the toggle beside long description text on narrow mobile layouts; align with AutoUpdateSection pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Exclude Playwright/ui-check-screenshots outputs from version control and update the lockfile after tauri-nspanel resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid NoSuchMethodError when installed APK dex lacks OpenLessAccessibilityService.isEnabled static bridge; query enabled services and heartbeat prefs directly. Co-authored-by: Cursor <cursoragent@cursor.com>
Add @keep and @JvmStatic on Rust-invoked bridge methods; default overlay service starts to startService and only START_RECORDING uses startForegroundService on API 26+; abort recording when foreground promotion fails. Co-authored-by: Cursor <cursoragent@cursor.com>
…ess#653) Add opt-in polishUnchanged detection, history-level repolish IPC, and UI; exclude translation history; preserve insert error codes on retry. Co-authored-by: Cursor <cursoragent@cursor.com>
…ssion Co-authored-by: Cursor <cursoragent@cursor.com>
Reduce idle WebView2 renderers by creating qa/less-computer/glow on demand and destroying on dismiss; add QA state snapshot for cold-start hydrate; lazy-load FloatingShell tabs and Settings sections for smaller main-window first paint. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
8 tasks
appergb
added a commit
that referenced
this pull request
Jun 19, 2026
Collaborator
|
感谢投入,但这个 PR 先关闭一下 🙏 主要问题是一个 PR 里捆绑了三块互不相关的改动,共 1715 行 / 47 个文件:
这种捆绑违反单一职责,审查、回归、出问题时回滚都很困难;而且重型构建 CI(Linux / Windows / macOS checks)此前没跑过,只有 建议按上面三个关注点拆成三个独立 PR,各自审查、各自合并。欢迎拆分后重新提交,关闭不代表否定其中任何一块。 |
katanumahotori
added a commit
to katanumahotori/openless
that referenced
this pull request
Jun 26, 2026
整形(polish)結果が空(finalText空)になると、履歴の「コピー」が空文字を コピーし、画面に見えている識別原文を UI から取り出せなかった。 - onCopy: finalText が空白のみのとき rawTranscript にフォールバック - 原文パネルに独立コピーボタン追加(rawTranscript がある時のみ表示) - 既存 common.copy/common.copied を流用、i18n 追加なし、フロントのみ 上流(Open-Less/openless)へ出す issue/PR 下書きを docs に追加。 既存の Open-Less#653 / 閉じた Open-Less#666・Open-Less#694(履歴再整形)とは重複しない別の 基礎的バグ(finalText 空・errorCode 未設定)として整理。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 26, 2026
jiangmuran
pushed a commit
that referenced
this pull request
Jun 27, 2026
… + copy button on raw panel (#752) When polishing returns an empty finalText (errorCode stays null), the History "Copy" button copied an empty string, so the raw transcript that is still visible in the UI could not be recovered. Re-transcribe does not apply here (ASR succeeded; polish is what failed). - onCopy: fall back to rawTranscript when finalText is blank - raw panel: add a dedicated copy button (shown only when rawTranscript exists) - reuse existing common.copy / common.copied, no new i18n; frontend-only Complements #653 (polish identical to raw); independent of the in-progress history re-polish work (#666/#694). No backend/IPC changes. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
QaStateSnapshotfor cold-start hydrate; lazy-load FloatingShell tabs and Settings sections to shrink main-window first paint and idle renderer count.Build.SUPPORTED_ABIS, accessibility state, ProGuard@Keepon bridge methods).done_messagebefore movingerror_codeinto session (fixes a move-after-use bug).Test plan
PR Type
Bug fix, Enhancement, Tests
Description
Lazy-create auxiliary webviews (qa, less-computer)
Android auto-update with stable/beta channels
Detect polish unchanged and allow history repolish
Fix JNI read of Build.SUPPORTED_ABIS
Diagram Walkthrough
flowchart LR subgraph Desktop A[WebView2 lazy-create] --> B[qa/less-computer/glow] C[Hide→destroy] --> D[Free memory] end subgraph Android E[AutoUpdateGate] --> F[stable/beta manifest] F --> G[Download+install] end subgraph History H[Polish unchanged detection] --> I[mark polishUnchanged] I --> J[Repolish button] endFile Walkthrough
28 files
Add repolish/show QA window commands; lazy webview creationDetect polish unchanged; resolve error codes; add testsAdd QA snapshot, repolish methods, style-pack resolutionAdd polish_unchanged_enabled pref; update commentsAdd repolish_history_entry commandAdd get_qa_window_state command and snapshot structRegister updater_logic moduleAdd autoInstallAndroid option; update dialog stringsRefactor state handling; add cold-start hydrateLazy load non-overview tabs and settings modalAdd repolish button and unchanged tagAdd QaStateSnapshot, polishUnchangedEnabled fieldsLazy load services, privacy, advanced tabsRestructure layout; separate toggle and check buttonAdd repolishHistoryEntry and getQaWindowState mocksShow channel-specific button labelsPass autoInstallAndroid to checkForUpdatesAdd Android auto-update toggle sectionAdd polish unchanged detection toggleCompose advanced settings sectionsLazy load privacy tabLazy load general tabLazy load services tabAdd script to verify pubkey consistencyAdjust overlay bridge for new featuresAlign heartbeat with Rust-side checksImprove install result reportingPermission handling adjustments3 files
Extract constants; fix JNI field read; add install checkRewrite accessibility checks via Settings.SecureUpdate for background update integration2 files
Add version compare, manifest URLs, pubkey; unit testsAdd polishUnchangedEnabled to test defaults7 files
Add Japanese translations for new featuresAdd Traditional Chinese translationsAdd Korean translationsAdd Simplified Chinese translationsAdd English translationsUpdate documentation for auto-updateUpdate build instructions3 files
Add release signing for manual dispatchSet create:false for auxiliary windows; update updater pubkeyAdd pubkey check job1 files
Dependency adjustments for lazy loading1 files