fix(ui): unify macOS shell top inset with sidebar/background surface#702
Merged
Conversation
The 28px top inset that clears the macOS overlay traffic lights sat on the content wrapper with no background, so it exposed the lighter WindowChrome glass (--ol-window-bg) as a full-width band above the sidebar and panel — reading as an extra top row that the Windows build (no inset) doesn't have. Paint that wrapper with the same --ol-app-shell-bg the sidebar/background already use, so the inset blends into one continuous surface with the panel card floating on top. One property; token carries its own light + dark values; no layout, token, or other UI changes.
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
appergb
pushed a commit
that referenced
this pull request
Jun 17, 2026
…ing accessibility gate Bundles the two macOS UX fixes already merged into beta: - #702 unify macOS shell top inset with sidebar/background surface - #703 require macOS Accessibility grant before first-run onboarding completes Version synced across package.json, package-lock.json, tauri.conf.json, Cargo.toml, Cargo.lock. Local release build verified (1.3.10-2 installs and runs; top bar seamless; first-run requires Accessibility).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What
Fixes the macOS-only "extra row at the top" of the main window: the sidebar/background and the title-bar strip now read as one continuous surface (matching the Windows look), with the panel card floating on top.
Root cause
The 28px top inset that clears the macOS overlay traffic lights sits on the content wrapper in
FloatingShell. That wrapper had no background, so the inset exposed the lighterWindowChromeglass (--ol-window-bg) as a full-width band above the sidebar and panel — reading as an extra top row. The Windows build has no inset (paddingTop: 0), so it never showed this.This is not a regression from a single PR — the 28px inset has existed since 1.3.8. What made the band visible was the beta theme refresh (Aura skin removed → new white-glass tokens), which changed
--ol-window-bgvs the shell surface.Fix
Paint the content wrapper with the same
--ol-app-shell-bgtoken the sidebar/background already use, so the inset blends into one continuous surface.Test plan
npx tsc --noEmit— cleanBase:
beta.PR Type
Bug fix
Description
Add background to content wrapper to blend with sidebar/background
Fixes visible band above sidebar/panel on macOS
One-line change; no layout or token modifications
Diagram Walkthrough
File Walkthrough
FloatingShell.tsx
Add shell background to content wrapperopenless-all/app/src/components/FloatingShell.tsx
background: 'var(--ol-app-shell-bg)'to the content wrapper divsurface