fix(asr): add MiMo provider to credential gate validation#713
Conversation
`ensure_asr_credentials()` did not handle the `xiaomi-mimo-asr` provider, causing it to fall through to the default Volcengine credential check. This blocked all MiMo ASR users with "请先在设置中填写火山引擎 ASR App Key". Added `is_mimo_provider()` to the credential gate condition so MiMo users are validated via `AsrApiKey` (same as Whisper/Bailian providers).
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
@claude 请审核(ASR 凭证门控):本 PR 把 MiMo provider 加入 重点请确认:
注意:这是 fork PR,主 CI 矩阵(macOS/Linux/Windows/Android checks)尚未运行,仅 pr_agent_job 通过。 |
|
Claude finished @appergb's task in 1m 39s —— View job ASR 凭证门控审查结果待办清单
1.
|
User description
问题描述
使用
xiaomi-mimo-asr作为 ASR provider 时,语音输入被拦截,报错:根本原因
ensure_asr_credentials()函数(位于coordinator/asr_wiring.rs)没有处理 MiMo provider。当前验证逻辑:
MiMo provider 不匹配任何条件,fall through 到第 5 步,被火山引擎凭证检查拦截。
修复方式
在第 4 步的条件中添加
is_mimo_provider(&active_asr),让 MiMo 走与其他 API Key 类型 provider 相同的验证路径:测试
xiaomi-mimo-asrprovider 成功完成语音输入PR Type
Bug fix
Description
Fix MiMo provider credential gate validation
Add
is_mimo_provider()to conditionDiagram Walkthrough
flowchart LR A["Credential gate"] --> B{"Provider?"} B -- "Whisper/Bailian/MiMo" --> C["Check API Key"] B -- "Other" --> D["Volcengine error"]File Walkthrough
asr_wiring.rs
Add MiMo provider to credential gate conditionopenless-all/app-tauri/src-tauri/src/coordinator/asr_wiring.rs
is_mimo_provider()to credential gate condition