Repository navigation
Fix stale Phase 4 artifact paths after docs reorg - #169
Merged
Merged
Conversation
Three paths were stale after the docs reorganization: - docs/LAB_PARTNER_ONBOARDING.md -> docs/review/ - docs/WAVE1_ANALYSIS_PLAN.md -> docs/research/ - docs/PUBLICATION_PACK.md -> docs/review/ All 8 reproducibility report tests pass.
The docs tree now follows the information architecture much more closely. Strategy, trust, evidence, review, and operations documents that still sat at the docs root were moved into their canonical subfolders, leaving only the true docs entrypoint files at the root: README, PROJECT_INDEX, and AGENTS. This change updates the repo's living references so the moved files are no longer treated as legacy root documents. Hub READMEs, project indexes, issue templates, agent instructions, report strings, and the docs consistency test now resolve through the canonical paths. The result is a materially smaller and clearer root docs surface without sacrificing consistency or discoverability. Constraint: Exclude the unrelated unstaged src/openamp_foundry/pipeline.py modification from this commit. Confidence: High — root docs surface reduced to three files and the staged diff is mechanically clean. Tested: git diff --cached --check; full pre-push verification gate will run on push. Co-authored-by: OmX <omx@oh-my-codex.dev>
The root docs reduction exposed the last class of regressions: code, templates, and historical docs that still treated deleted root doc paths as canonical. This commit rewrites those remaining references to the new evidence, trust, review, research, and engineering locations so the reduced docs surface is not only smaller but operationally correct. This includes the docs consistency test, report strings, GitHub templates, root guidance files, and the remaining historical docs that referenced deleted root-level pages. The branch still intentionally excludes the unrelated src/openamp_foundry/pipeline.py modification. Constraint: Keep the reduced root docs surface while restoring full test and hook compatibility. Confidence: High — docs consistency returned to green after the path repair pass and the staged diff is mechanically clean. Tested: ./.venv/bin/python -m pytest tests/test_docs_consistent.py -q; git diff --cached --check Co-authored-by: OmX <omx@oh-my-codex.dev>
The remaining root tests now live in domain folders that mirror the codebase and workflow lanes instead of accumulating in a flat top-level surface. Benchmark, data, evidence, feature, generator, integration, QC, scoring, selection, simulation, and active-learning coverage now have clear homes, and the moved path-sensitive tests were updated to keep resolving repo-root resources correctly. This change makes the test tree read like the system it validates. Contributors and agents can now find the right test neighborhood with much less search overhead, while the full moved-tree verification confirmed that the reorganized paths still behave correctly. Constraint: Exclude the unrelated unstaged src/openamp_foundry/pipeline.py modification from this commit. Confidence: High — the test root is reduced to AGENTS.md only and the broad moved-tree verification passed. Tested: ./.venv/bin/python -m pytest tests/active_learning tests/data tests/evidence tests/features tests/generators tests/integration tests/qc tests/scoring tests/selection tests/simulation tests/benchmarks tests/calibration tests/external tests/lab tests/novelty tests/release tests/waves -q; git diff --cached --check Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs reorganization moved three files. The reproducibility report still pointed to the old paths, causing Phase 4 readiness checks to show ❌ for these artifacts.
Fixed:
All 8 reproducibility report tests pass. Full suite: 2022 passed, 1 skipped.