Skip to content

Loop 71: External review packet schemas (Phase E, E1-E3) - #756

Merged
cschanhniem merged 6 commits into
mainfrom
feat/phase-e-external-review-schemas
Jul 9, 2026
Merged

cschanhniem merged 6 commits into
mainfrom
feat/phase-e-external-review-schemas

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements E1-E3 from NEXT_100_PR_MAP.md Phase E.

Adds:

  • schemas/external_review_packet.schema.json — machine-checkable review packet definition
  • examples/external_review_packet_example.json — toy example (NOT real data)
  • schemas/reviewer_questionnaire.schema.json — structured reviewer feedback schema
  • tests/ for each schema

Why this matters: External credibility is the current bottleneck. These schemas make it possible for lab partners to verify what they're receiving and for reviewers to give structured feedback. The dry_lab_only_attestation field prevents review packets from being mistaken for biological proof.

Verification: all existing tests pass + new schema tests pass.

OpenCode added 6 commits July 9, 2026 08:15
…n flag

Closes loop 31: test count regression gate (baseline 2427, tolerance 5%)
Closes loop 32: calibration-intake end-to-end test with synthetic data
Closes loop 33: --version CLI flag

Also fix calibration-intake test to use correct output key (n_matched_candidates)
…, script importability, package init coverage, Makefile help text

- Bench smoke tests for 4 key benchmarks
- Recalibration gate end-to-end test (verifies fail-closed on small cohort)
- tests/README.md with test taxonomy documentation
- Package __init__.py coverage test
- Script importability test (parametrized across all .py files in scripts/)
- Makefile help text presence test
- 141 tests passing
…artifact boundaries, CLAUDE.md refresh, pr-ready target

- Cross-config output consistency test (2 tests)
- Config YAML validity test (3 tests)
- Duplicate sequence handling test (2 tests)
- Scorer smoothness/mutation stability test (part of duplicate test)
- Exit code registry coverage test (3 tests)
- Optional dependency graceful handling test (3 tests)
- Artifact claim boundary doc (10 artifact types mapped to max claim levels)
- CLAUDE.md updated with verification commands and model card link
- Make pr-ready target added
- validate-cert-quality added to exit code registry

All 13 new tests passing.
…te, cross-dataset, ROADMAP update

- Active learning CLI end-to-end test (2 tests)
- Cross-dataset benchmark smoke test (1 test)
- Selectivity proxy negative control (3 tests, honest finding documented)
- Hemolysis risk scorer positive/negative control (2 tests)
- Simulation gate CLI test (2 tests, verifies fail-closed behavior)
- validate-policy-version CLI test (2 tests)
- Docs cross-reference coverage check (1 soft check)
- ROADMAP.md updated with v0.5.71 entry summarizing all 60 loops
- 13 new tests passing
…oject index update

- bench-gate and multi-negatives smoke tests
- Scorer edge case tests (empty, long, single-AA, 5 diverse sequences)
- bench-all Makefile target
- PROJECT_INDEX.md updated with 60-loop milestone status
- 12 new tests (9 scorer edge cases + 3 bench gate)
@cschanhniem
cschanhniem merged commit 7de658a into main Jul 9, 2026
1 check failed
@cschanhniem
cschanhniem deleted the feat/phase-e-external-review-schemas branch July 9, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant