Repository navigation
Loop 73: Rejection reason taxonomy schema (Phase F F3) - #758
Merged
Merged
Conversation
Machine-readable rejection reason taxonomy for OpenAMP candidate failures. Covers 21 reasons across 6 pipeline stages with severity, evidence impact, and stage classification. - schemas/rejection_taxonomy.schema.json — JSON Schema for taxonomy entries - examples/rejection_taxonomy_example.json — 21-entry complete taxonomy - docs/evidence/REJECTION_TAXONOMY.md — comprehensive reference doc - tests/evidence/test_rejection_taxonomy_schema.py — 19 tests - docs/evidence/METRICS_CURRENT.md — v0.5.74 entry (2698 tests) - docs/research/ROADMAP.md — v0.5.74 entry - tests/test_test_count_regression.py — baseline 2698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Adds machine-readable rejection reason taxonomy for OpenAMP candidate failures — schema, example, doc, and 19 tests.
New files:
schemas/rejection_taxonomy.schema.json— JSON Schema Draft 2020-12 defining rejection taxonomy entries (code, category, severity, evidence_impact, applies_at_stage, related_reason_category)examples/rejection_taxonomy_example.json— 21-entry taxonomy covering all 6 pipeline stages (pre_selection, pipeline, diversity, reviewer, lab, lifecycle)tests/evidence/test_rejection_taxonomy_schema.py— 19 tests covering schema validation, example validation, coverage completeness, code uniquenessModified files:
docs/evidence/REJECTION_TAXONOMY.md— comprehensive reference with hierarchy tables, severity/evidence-impact definitions, cross-referencesdocs/evidence/METRICS_CURRENT.md— v0.5.74 entry (2698 tests)docs/research/ROADMAP.md— v0.5.74 entrytests/test_test_count_regression.py— baseline 2698Why
Phase F F3 is the foundation for F4 (failed-candidate report generator) and F5 (safe-publication filter). Without a machine-checkable rejection taxonomy, downstream tools have no shared vocabulary for why candidates fail. This bottlenecks external reviewability and negative-result analysis.
Evidence
python3 -m pytest tests/evidence/test_rejection_taxonomy_schema.py -v— 19/19 passedpython3 -m pytest tests/test_test_count_regression.py -v— baseline check passed (2698)make agent-check— all checks passedSafety impact
None directly. The taxonomy describes rejection reasons only; it does not change how candidates are selected, scored, or released. All 21 rejection codes are descriptive — they standardize existing pipeline behavior.
Proof level
Level 1 (reproducible dry-lab feature). The schema and example are deterministic, versioned, and validated.
Limitations
Human review needed
No. Docs-only schema addition with tests.