Skip to content

feat: Phase F F3 rejection reason entry schema -- controlled vocabulary (RJR-) for pipeline rejections enables failure analysis - #854

Merged
cschanhniem merged 1 commit into
mainfrom
feat/f3-rejection-reason-entry
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/f3-rejection-reason-entry

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Summary

  • RejectionReasonEntry: 11 fields, controlled taxonomy of rejection stages and reasons
  • 9 validation rules: RJR- prefix, 3 non-empty strings, rejection_stage in {7 values}, rejection_reason in {9 values}, rejection_confidence in {high/medium/low/uncertain}, ISO date, notes<=400 chars, manual_exclusion requires notes, borderline=True blocks high confidence
  • 3 warnings: uncertain confidence, borderline without notes, safety_policy_block without notes
  • 63 tests; BASELINE 5162->5225
  • CLI: openamp-foundry rejection-reason-check
  • Implements Phase F F3 — enables machine-readable analysis of why candidates are rejected

…ry for pipeline rejections, enables failure analysis and calibration loop learning
@cschanhniem
cschanhniem merged commit ef34cfa into main Jul 10, 2026
1 check failed
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…chine-verifiable verdict comparing pipeline vs cheap baseline; prevents performance claims without named baseline (#854) (#1013)

VALID_CBR_VERDICTS (4: pipeline_superior/tied/baseline_superior/insufficient_data),
VALID_BASELINE_METHODS (5: charge_only_rank/length_only_rank/random_selection/charge_length_combined/hydrophobicity_only_rank),
VALID_CBR_METRICS (4: auroc/hit_rate/top_k_precision/ndcg).
SUPERIORITY_THRESHOLD=0.05, MIN_SAMPLE_SIZE=5; metric_delta auto-computed.
Adds Phase Y baseline-vs-pipeline accountability section to NEXT_100_PR_MAP.md.
62 tests; BASELINE updated 10498->10560.

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant