Skip to content

feat: Phase F F2 negative result archive summary schema -- validates NRR- batch is complete before archiving - #855

Merged
cschanhniem merged 1 commit into
mainfrom
feat/f2-negative-result-archive-summary
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/f2-negative-result-archive-summary

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Summary

  • NegativeResultArchiveSummary: 11 fields, index record for a batch of NRR- entries
  • 9 validation rules: NAS- prefix, 3 non-empty strings, ISO date, count>=0, count matches len(ids), all ids start with NRR-, completeness_confirmed=True enforced, all_results_have_reason=True enforced, notes length
  • 3 warnings: zero results unusual, empty notes, large archive (>50)
  • 63 tests; BASELINE 5225->5288
  • CLI: openamp-foundry negative-result-archive-check
  • Implements Phase F F2 — prevents incomplete negative result archives

…NRR- batch completeness before archiving, prevents silent failure record gaps
@cschanhniem
cschanhniem merged commit e308a96 into main Jul 10, 2026
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…-explanation gate; flags when charge/length alone explains pipeline selections (#855) (#1014)

VALID_FIA_VERDICTS (5: multi_feature_signal/charge_dominated/length_dominated/hydrophobicity_dominated/insufficient_data),
VALID_FEATURE_IMPORTANCE_LEVELS (4), VALID_AUDIT_FEATURES (8), DOMINATION_THRESHOLD=0.80.
importance_level auto-assigned from score; top_feature/charge_score/length_score auto-extracted.
Verdict: charge_dominated when charge_explains_fraction>=0.80; min 2 features required.
dry_lab_only=True; 50 tests. BASELINE updated 10560->10610.

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant