Skip to content

feat: Phase E E10 expert review example package schema -- ERP- CI-checkable review template with mock-only enforcement - #870

Merged
cschanhniem merged 1 commit into
mainfrom
feat/e10-expert-review-example-package
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/e10-expert-review-example-package

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Summary

  • ExpertReviewExamplePackage (ERP-): 14 fields, self-contained expert-review demonstration package
  • 16 validation rules: ERP- prefix, pipeline_version+example_version non-empty, creation_date ISO, review_domain vocab (6), mock_candidates 1-10 entries with ID prefix enforcement (MOCK-/TOY-/EXAMPLE-/DEMO-/TEST-), at least one candidate included, Likert 1-5 clarity rating, synthesis_recommendation vocab (4: proceed/proceed_with_conditions/defer/reject), reviewer_comments non-empty ≤500 chars, dry_lab_only=True enforced, is_example_data=True enforced, example_use_case non-empty, summary non-empty ≤400 chars, notes ≤300 chars
  • 3 warnings: clarity_rating ≤2, excluded candidates, notes empty
  • 63 tests; BASELINE 6107→6170
  • CLI: openamp-foundry expert-review-example-package-check
  • Implements Phase E E10 — safe demonstration package that cannot accidentally leak real candidates; is_example_data gate enforced in CI

…ckable template with enforced mock-only candidate IDs
@cschanhniem
cschanhniem merged commit 9cffe5f into main Jul 10, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant