Repository navigation
feat: Phase C C10 benchmark governance CI -- rejects missing BMC cards for governed benchmark scripts - #885
Merged
Conversation
…s for governed benchmark scripts (#884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements C10 from NEXT_100_PR_MAP: benchmark governance CI check.
What
src/openamp_foundry/evidence/benchmark_governance.py:check_governance()+format_governance_report()+GovernanceReportdataclass +BenchmarkGovernanceErrorGOVERNED_SCRIPTSfrozenset +SCRIPT_TO_BMC_IDmapping (5 scripts, BMC-0001 to BMC-0005)is_compliant=Falsewith violation detailWhy
Prevents benchmark sprawl: new benchmark scripts must declare a BMC- card in BENCHMARK_REGISTRY before they can be governed. The SCRIPT_TO_BMC_ID mapping is the contract — add here before adding a script.
Disconfirming pass