Repository navigation
feat: Phase E E1 external review packet schema -- ERP- validation with dry-lab cap, safety attestation enforcement, 63 tests - #895
Merged
Conversation
…h dry-lab cap, safety attestation enforcement, 63 tests (#894)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E1 from NEXT_100_PR_MAP: external review packet Python module.
What
external_review_packet.py:ExternalReviewPacket+CandidateEntry+BenchmarkSummary+CalibrationSummary+SafetyAttestations+PacketValidationResultvalidate_external_review_packet(): 14 validation rules, dry-labproof_ladder_levelcap at 2format_external_review_packet(): human-readable output with VALID/INVALID statusdry_lab_only_attestationmust be True,no_known_toxicity_claimmust be True, limitations requiredWhy
The JSON schema for ERP- packets already existed but no Python module enforced it. Without Python-level validation, a review packet could be sent to external reviewers with
dry_lab_only_attestation=Falseorproof_ladder_level=5— both misrepresent what a dry-lab pipeline can claim.Disconfirming pass
proof_ladder_level > 2for dry-lab artifacts is now blocked, not just warned