Repository navigation
feat: Phase E E5 pilot pre-registration schema -- PRR- record freezes selection thresholds before wet-lab, prevents post-hoc adjustment, 63 tests - #896
Merged
Conversation
… selection thresholds before wet-lab, prevents post-hoc adjustment, 63 tests (#896)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E5 from NEXT_100_PR_MAP: non-protocol pilot pre-registration schema.
What
pilot_preregistration.py:PilotPreregistration+ScoreThreshold+PreregistrationValidationResultvalidate_pilot_preregistration(): 14 validation rulesformat_pilot_preregistration(): human-readable output with VALID/INVALID/NOTICEVALID_OUTCOME_METRICS: 8 controlled vocabulary termsVALID_AMENDMENT_REASONS: 5 controlled termsdry_lab_only_declaration=Truerequired, score thresholds declared before experiment, positive/negative controls requiredWhy
Post-hoc threshold adjustment is the most common form of silent overclaiming in computational-to-experimental pipelines. A locked PRR- record with frozen thresholds is the contract between dry-lab selection and wet-lab execution. Without pre-registration, "we selected candidates with score > 0.7" can become "score > 0.5 (after checking results)" with no audit trail.
Disconfirming pass
amendment_reasonsvocabulary limits what can be changed and why