Repository navigation
feat: Phase E E2 example external review packet -- toy data factory with 63 tests, CI-checkable, ERP-TOY-0001 validates all rules - #898
Merged
Conversation
…ith 63 tests, CI-checkable, ERP-TOY-0001 validates all rules (#898)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E2 from NEXT_100_PR_MAP: example external review packet using toy/mock data.
What
example_external_review_packet.py: builds ERP-TOY-0001 with 3 toy candidates (TOY-0001, TOY-0002, TOY-0003)build_example_packet()factory: all TOY- prefix candidates, dry_lab_only_attestation=True, proof_ladder_level=1validate_example_packet_passes(): CI-checkable gate that raises ValueError if example regressesbuild_toy_candidate_entry(): enforces TOY- prefix, rejects non-toy IDsWhy
Partners receiving external review packets need a worked example to understand the format. The example packet is CI-enforced: if validation rules change in a way that breaks the example, the test suite catches it immediately.
Disconfirming pass