Repository navigation
chore: sync PR #102/#103 tracking + Nle regression guard - #95
Merged
Merged
Conversation
- tests/test_presynth_qc.py: add assertion that Met flag contains "Nle" to guard against silent removal of norleucine recommendation (PR #102 regression guard) - docs/ROADMAP.md: add v0.7.x entries for PR #102 (Met/Nle flag) and PR #103 (ASSAY_PREREGISTRATION 5-family limitations block); list all 5 families explicitly (SEED-003 pre-existing + SEED-007/005 added) - docs/DISCOVERY_PREDICTION.md: add post-PR #102 and post-PR #103 tracking notes in reverse-chronological order; correct 5-family enumeration to include SEED-003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_met_flag_in_flags_listnow asserts"Nle" in met_flags[0]— silently dropping the norleucine recommendation from the Met oxidation flag will now fail the test (closes gap from PR feat: expanded benchmark (95 AMPs + 96 decoys, AUROC 0.7832) + DKP risk + stability calibration #102)Test plan
pytest tests/test_presynth_qc.py— 129/129 pass including the new Nle assertionpytest— 1304/1304 pass🤖 Generated with Claude Code