feat: add basic authentication#14
Open
lenapenha wants to merge 3 commits into
Open
Conversation
glitchedmob
requested changes
May 18, 2026
Member
There was a problem hiding this comment.
Can we actually adjust this such that the ADMIN_USER_PASSWORD we put in configuration is prehashed? That means the only hashing we would need to do would be on the incoming data from the http call.
That way even if someone gets a hold of the configuration they still don't get the actual password
I would suggest we adjust the naming of the configuration value to be ADMIN_USER_HASHED_PASSWORD
glitchedmob
requested changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic authentication to the app