Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[wip] MT-14 flag for missing override keyword - #2

Open
DariuszRosolek wants to merge 1 commit into
Open-Transactions:masterfrom
matterfi:MT-14-improve-warnings
Open

[wip] MT-14 flag for missing override keyword#2
DariuszRosolek wants to merge 1 commit into
Open-Transactions:masterfrom
matterfi:MT-14-improve-warnings

Conversation

@DariuszRosolek

Copy link
Copy Markdown

No description provided.

Comment thread set-compiler-flags.cmake
elseif(${CMAKE_CXX_COMPILER_ID} MATCHES Clang)
set(${PROJECT_NAME}_WARNING_FLAGS
"${${PROJECT_NAME}_WARNING_FLAGS} -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-covered-switch-default -Wno-exit-time-destructors -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-padded -Wno-undefined-func-template -Wno-unknown-warning-option -Wno-weak-template-vtables -Wno-weak-vtables"
"${${PROJECT_NAME}_WARNING_FLAGS} -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-covered-switch-default -Wno-exit-time-destructors -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-padded -Wno-undefined-func-template -Wno-unknown-warning-option -Wno-weak-template-vtables -Wno-weak-vtables -Winconsistent-missing-override"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Winconsistent-missing-override on this line is unnecessary because it is already enabled by -Weverything.

@justusranvier
justusranvier force-pushed the master branch 7 times, most recently from 273d9c3 to 66ae67d Compare May 17, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants