Skip to content

Modify resource dock style for better visual impact - #117

Merged
Nozzit merged 3 commits into
OpenAEC-Foundation:mainfrom
manuvarkey:main
Sep 14, 2026
Merged

Nozzit merged 3 commits into
OpenAEC-Foundation:mainfrom
manuvarkey:main

Conversation

@manuvarkey

Copy link
Copy Markdown
Contributor

What and why

See #115 (comment)

How it was verified

  • npm run verify green

Works fine using npm run dev. npm run verify raises following error.

> open-planner-studio@2026.9.0 verify
> npm run typecheck && npm run lint && npm test && npm run verify:examples && npm run verify:docs && npm run verify:i18n && npm run verify:store-boundaries && npm run verify:gantt-boundaries && npm run verify:cycles


> open-planner-studio@2026.9.0 typecheck
> tsc --noEmit && tsc --noEmit -p tsconfig.tests.json

src/services/pdf/bidiShape.ts:29:1 - error TS2578: Unused '@ts-expect-error' directive.

29 // @ts-expect-error -- bidi-js heeft geen type-declaraties; hieronder lokaal getypeerd.
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in src/services/pdf/bidiShape.ts:29

Seems to be unrelated. To be confirmed.

Does this touch

  • Project data — round-trips through the IFC layer, and tested?
  • Scheduling logic — case added to tests/planning/?
  • User-visible text — goes through t(...), and all fourteen locales filled in?
  • @tauri-apps/* — behind isTauri() or a dynamic import, so the browser
    build keeps working?

Documentation

@manuvarkey
manuvarkey requested a review from Nozzit as a code owner September 10, 2026 16:53

@Nozzit Nozzit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for your PR!
I would prefer a method where we remove the red dots altogether and instead only show a warning sign left to the number input field. This saves horizontal space and is more clear for the user.
Let me know if you think you can do that yourself or if I should close this PR and do this myself.

@manuvarkey

Copy link
Copy Markdown
Contributor Author

Hi. I have made the changes. Please see if this is what you intended.

image

@Nozzit Nozzit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is exactly what I had in mind!
There is one small change to the documentation needed, I'll do that myself this time.
Thanks again for the PR, it is the first one from someone outside of the open aec foundation for the open planner studio!

@Nozzit
Nozzit merged commit 87454ad into OpenAEC-Foundation:main Sep 14, 2026
4 checks passed
Nozzit added a commit that referenced this pull request Sep 14, 2026
…r-review-o2ve2b

docs(gids): Resourcedock beschrijft kleurbalkje en waarschuwingsdriehoek (na #117)
pull Bot pushed a commit to pepe57/open-planner-studio that referenced this pull request Sep 14, 2026
…oek (OpenAEC-Foundation#117)

PR OpenAEC-Foundation#117 (manuvarkey) vervangt in het compacte Resources-paneel het rood/groene
bolletje door een rood waarschuwingsdriehoekje dat alleen bij overallocatie
verschijnt, links van het Max.-eenheden-veld, en maakt van het kleurvlakje een
verticaal balkje. De gids gids-resources-histogram.md (nl + en) beschreef nog het
oude bolletje; verify:docs vangt inhoudelijke drift niet, dus met de hand
bijgewerkt. Mergen ná OpenAEC-Foundation#117.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GFfkcDCZ9v4T18z5S5orHz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants