-
Notifications
You must be signed in to change notification settings - Fork 7
[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1a7fced
[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI
RomuDeuxfois 839f0f5
[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI
RomuDeuxfois 45f6ff2
[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI
RomuDeuxfois 9e84208
docs: add PSScriptAnalyzer local dev instructions to README (#148)
Copilot a7305c3
Merge branch 'release/current' into improvment/PSScriptAnalyzer
RomuDeuxfois 11cfce4
docs: add PSScriptAnalyzer local dev instructions to README (#148)
RomuDeuxfois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PSScriptAnalyzer settings for the Windows installer scripts. | ||
| # Rules excluded here are intentional choices, not oversights: | ||
| # - Write-Host is used deliberately for interactive console output during installation. | ||
| # - $Password must remain [string] because the NSIS installer expects plain-text input. | ||
| @{ | ||
| ExcludeRules = @( | ||
| 'PSAvoidUsingWriteHost', | ||
| 'PSAvoidUsingPlainTextForPassword' | ||
| ) | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| $ErrorActionPreference = 'Stop' | ||
|
|
||
| # Ensure NuGet provider is available (required for Install-Module on fresh machines / CI runners) | ||
| if (-not (Get-PackageProvider -Name NuGet -ListAvailable -ErrorAction SilentlyContinue)) { | ||
| Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser | Out-Null | ||
| } | ||
|
|
||
| # Install PSScriptAnalyzer if not already present, then load it | ||
| $analyzer = Get-Module -ListAvailable -Name PSScriptAnalyzer | Select-Object -First 1 | ||
|
|
||
| if (-not $analyzer) { | ||
| Write-Host "Installing PSScriptAnalyzer ..." -ForegroundColor Yellow | ||
| Install-Module -Name PSScriptAnalyzer -Force -SkipPublisherCheck -Scope CurrentUser | ||
| } | ||
|
|
||
| Import-Module PSScriptAnalyzer -Force | ||
|
|
||
| # Lint all installer scripts | ||
| $settings = Join-Path $PSScriptRoot 'PSScriptAnalyzerSettings.psd1' | ||
| $results = Invoke-ScriptAnalyzer -Path "$PSScriptRoot\*.ps1" -Recurse -Settings $settings | ||
|
|
||
| if ($results) { | ||
| $results | Format-Table -AutoSize | ||
| Write-Host "$($results.Count) issue(s) found." -ForegroundColor Red | ||
| exit 1 | ||
| } else { | ||
| Write-Host "No issues found." -ForegroundColor Green | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could you clarify in the README how to launch it in local dev env ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can you add the demands from the comment on the code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damgouj we added it :)
Thank you for the review !