fix: preserve key casing in slots migration wrapper

[Mixficsol]

fix: #3291

Summary by CodeRabbit

• Bug Fixes
  • Migration commands now preserve the key’s original letter casing instead of converting it to lowercase.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 385bf8ab-2245-426f-92d4-400be7745c37

📥 Commits

Reviewing files that changed from the base of the PR and between 536c414 and 64216a5.

📒 Files selected for processing (2)

• src/pika_slot_command.cc
• tools/pika_migrate/src/pika_slot_command.cc

💤 Files with no reviewable changes (2)

• tools/pika_migrate/src/pika_slot_command.cc
• src/pika_slot_command.cc

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes key lowercasing from SlotsMgrtExecWrapperCmd::DoInitial in the main command implementation and the migration tool. Migration now receives keys with their original casing.

Changes

Migration key handling

Layer / File(s)	Summary
Preserve key casing before migration src/pika_slot_command.cc, tools/pika_migrate/src/pika_slot_command.cc	SlotsMgrtExecWrapperCmd::DoInitial no longer lowercases the parsed migration key before calling migration logic.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 64216

The change preserves original key casing during slot migration, addressing failures to locate keys containing uppercase characters. No remaining merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states that the change preserves key casing in the slots migration wrapper. It is concise and directly matches the primary change.
Linked Issues check	✅ Passed	The pull request removes the lowercasing step from SlotsMgrtExecWrapperCmd::DoInitial in both affected implementations. This preserves the original key casing and addresses issue #3291.
Out of Scope Changes check	✅ Passed	The changes are limited to removing the incorrect key lowercasing in the production and migration tool implementations. Both changes directly support issue #3291, and no unrelated changes are shown.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/slotsmgrt-preserve-key-case

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[guangkun123]

可以

[guangkun123]

可以