Skip to content

feature/(auth): Handle users with invalid email addresses in OAuth ca… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongwei1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature/(auth): Handle users with invalid email addresses in OAuth ca… #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/routes/login/[provider]/callback/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,15 @@ export async function GET(event: RequestEvent): Promise<Response> {
);
logger.debug('Full current user data:', user);

if (user.user_id && user.email) {
if (user.user_id) {
// Check if email is valid (not a placeholder)
const hasValidEmail = user.email && !user.email.endsWith('@noemail.local');

if (!hasValidEmail) {
logger.warn(`User ${user.user_id} logged in without valid email. Email: ${user.email || 'null'}`);
logger.warn('This user should update their email address in the system.');
}

// Store user data in session
const { session } = event.locals;
await session.setData({
Expand All @@ -219,14 +227,26 @@ export async function GET(event: RequestEvent): Promise<Response> {
});
await session.save();
logger.debug('Session data set:', session.data);

// Optionally redirect to profile page if email is invalid
// Uncomment the following lines to force email update:
// if (!hasValidEmail) {
// return new Response(null, {
// status: 302,
// headers: {
// Location: `/profile?warning=${encodeURIComponent('Please update your email address')}`
// }
// });
// }

return new Response(null, {
status: 302,
headers: {
Location: `/`
}
});
} else {
logger.error('Invalid user data received from OBP - missing user_id or email:', user);
logger.error('Invalid user data received from OBP - missing user_id:', user);

// Clean up the state cookie
event.cookies.delete('obp_oauth_state', {
Expand Down