Refapp 1299 multiple ssas v2#6
Open
ghost wants to merge 4 commits into
Open
Conversation
ghost
requested a review
from 
kbendyk
suggested changes
Jun 24, 2022
Contributor
kbendyk
left a comment
kbendyk
left a comment
There was a problem hiding this comment.
let's discuss on monday.
|
|
||
| // UpdateSSA - update the main ssa of the AuthoriserBuilder by popping the first one from ssas | ||
| func (b *AuthoriserBuilder) UpdateSSA() error { | ||
| if len(b.ssas) == 0 && b.ssasPresence { // return error if there is not enogh SSAs |
Contributor
There was a problem hiding this comment.
- ssaPresence - rename to ssaPresent or isSsaPresent after checking current convention
- Looks like ssaPresence flag is alway required, rewrite to make it obvious - exit early
- enogh - typo
| // CheckMissingSSAs - Check if b.missingSSAs was updated (default = 0) | ||
| func (b AuthoriserBuilder) CheckMissingSSAs() error { | ||
| if b.missingSSAs > 0 { | ||
| return errors.New(fmt.Sprintf("invalid amout of SSAs provided in the config - missing: %d", b.missingSSAs)) |
| WithTransportCertSubjectDn(transportCertSubjectDn) | ||
| WithTransportCertSubjectDn(transportCertSubjectDn). | ||
| WithSSAs(ssas). | ||
| WithSSAsPresence(SSAsPresents) |
Contributor
There was a problem hiding this comment.
Please explain why this method is necessary.
Author
There was a problem hiding this comment.
This method is used to detect if multiple or single SSA was set in the config file. The information is stored under ssasPresence field and it is used to decide if SSAs mechanism is required.
Potentially it might be moved to WithSSAs method while SSAs slice is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.