Fixes #610 expiration role invite#748
Merged
Merged
Conversation
…ve expiration date
…shing (due to null value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the feature to specify the number of days the user can have a role, similar to the role configuration
This PR includes a fix where multiple roles with different expiration dates the most restrictive expriation is picked instead of the date. Example: Role 1 (1 jan 2027) and Role 2 (1 jan 2028). The old situation picked 1 jan 2028 for both roles when combined in 1 invitation. The new situation picks 1 jan 2027. In case the user wants to specify per role: send 2 invitations
Also fixes: #743