Skip to content

test(ci): quarantine flaky macOS test_copy_prompt_from_input_honor_ps1_enabled#212

Merged
BunsDev merged 1 commit into
mainfrom
test/quarantine-copy-prompt-macos
Jul 18, 2026
Merged

test(ci): quarantine flaky macOS test_copy_prompt_from_input_honor_ps1_enabled#212
BunsDev merged 1 commit into
mainfrom
test/quarantine-copy-prompt-macos

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 18, 2026

Copy link
Copy Markdown
Member

Description

What: Quarantines the flaky macOS integration test
shell_integration_tests::test_copy_prompt_from_input_honor_ps1_enabled in
.config/nextest.toml.

Why: It intermittently panics with No position for Copy prompt (a layout
step that finds no position for the "Copy prompt" affordance) on loaded macOS
runners — exhausting the default integration retries = 2 in a single run,
despite being unrelated to the code under test. It surfaced on the Run MacOS tests job for #209 (agent-panel/cli_chat changes that touch nothing in shell
integration/clipboard).

How: A macOS-scoped override isolates the test to a single-thread test-group
(copy-prompt-quarantine, reducing contention that starves layout) and raises
its retries to 4, mirroring the repo's existing settings-file-reload isolation
and update_manager platform-retry patterns. The override is temporary — to be
removed once the root cause is fixed.

Linked Issue

Closes #211 (tracks the root-cause investigation and eventual removal of the
override).

Testing

  • .config/nextest.toml parses; override schema mirrors the existing
    update_manager (platform host cfg) + settings-file-reload (test-group)
    entries. ./script/check_ai_attribution + ./script/check_rebrand pass.
  • Config-only; no code build. The override takes effect on the next macOS CI run.

Agent Mode

Copilot AI review requested due to automatic review settings July 18, 2026 09:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR mitigates flakiness in the macOS CI suite by quarantining the shell_integration_tests::test_copy_prompt_from_input_honor_ps1_enabled integration test in nextest configuration, reducing contention and increasing retries on macOS while the root cause is investigated (tracked by #211).

Changes:

  • Added a dedicated nextest test-group (copy-prompt-quarantine) limited to max-threads = 1.
  • Added a macOS-scoped profile.ci override to run the flaky test in that group and increase its retries to 4.
  • Documented the rationale and linked the follow-up issue for eventual removal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BunsDev
BunsDev merged commit 7b65c38 into main Jul 18, 2026
37 of 40 checks passed
@BunsDev
BunsDev deleted the test/quarantine-copy-prompt-macos branch July 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky macOS integration test: shell_integration_tests::test_copy_prompt_from_input_honor_ps1_enabled

2 participants