test(ci): quarantine flaky macOS test_copy_prompt_from_input_honor_ps1_enabled#212
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates flakiness in the macOS CI suite by quarantining the shell_integration_tests::test_copy_prompt_from_input_honor_ps1_enabled integration test in nextest configuration, reducing contention and increasing retries on macOS while the root cause is investigated (tracked by #211).
Changes:
- Added a dedicated nextest test-group (
copy-prompt-quarantine) limited tomax-threads = 1. - Added a macOS-scoped
profile.cioverride to run the flaky test in that group and increase its retries to 4. - Documented the rationale and linked the follow-up issue for eventual removal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What: Quarantines the flaky macOS integration test
shell_integration_tests::test_copy_prompt_from_input_honor_ps1_enabledin.config/nextest.toml.Why: It intermittently panics with
No position for Copy prompt(a layoutstep that finds no position for the "Copy prompt" affordance) on loaded macOS
runners — exhausting the default integration
retries = 2in a single run,despite being unrelated to the code under test. It surfaced on the
Run MacOS testsjob for #209 (agent-panel/cli_chat changes that touch nothing in shellintegration/clipboard).
How: A macOS-scoped override isolates the test to a single-thread test-group
(
copy-prompt-quarantine, reducing contention that starves layout) and raisesits retries to 4, mirroring the repo's existing
settings-file-reloadisolationand
update_managerplatform-retry patterns. The override is temporary — to beremoved once the root cause is fixed.
Linked Issue
Closes #211 (tracks the root-cause investigation and eventual removal of the
override).
Testing
.config/nextest.tomlparses; override schema mirrors the existingupdate_manager(platform host cfg) +settings-file-reload(test-group)entries.
./script/check_ai_attribution+./script/check_rebrandpass.Agent Mode