docs(spec): correct Familiar-retirement plan (v2 — real entanglement map)#217
Merged
Merged
Conversation
…rver-API entanglement)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Familiar-panel retirement implementation plan to reflect the real dependency entanglement between ai_assistant UI code and the server-API/auth data types, reframing the work as an extraction-first refactor rather than a straight deletion.
Changes:
- Rewrites the plan as “v2” with an explicit UI-vs-data dependency map and corrected keep/delete sets.
- Introduces an extraction-first task order (move server-API-needed dialogue types into a UI-free module before unwiring/deleting UI).
- Clarifies scope options (panel-only retirement vs full hosted-AI server_api dialogue retirement) and calls out key risks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+17
| > 2. **The UI knot is fused to the AI server-API data layer (must survive):** | ||
| > - `app/src/server/server_api/ai.rs` imports `ai_assistant::utils::TranscriptPart` (6 sites) and `ai_assistant::requests::GenerateDialogueResult` | ||
| > - `app/src/auth/mod.rs` imports `ai_assistant::requests::REQUEST_LIMIT_INFO_CACHE_KEY` |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs-only. Corrects
PLAN-2d-task4-familiar-retirement.md(v1 → v2) after a real execution attempt revealed the plan's delete-set was wrong.Finding: the Familiar panel is not a cleanly-separable cluster.
panel.rs ↔ transcript.rs ↔ utils.rsare mutually circularly dependent, and that UI knot is fused to the AI server-API data layer (server_api/ai.rsusesutils::TranscriptPart+requests::GenerateDialogueResult;authusesrequests::REQUEST_LIMIT_INFO_CACHE_KEY). So retirement is a data-vs-UI extraction refactor that touches theserver_apicompile, not a deletion of a "dead backend."v2 rewrites the plan with: the true dependency map (keep-set vs delete-set), an extraction-first task order (pull the AI-dialogue data types into a UI-free module before deleting the UI knot), the scope decision (panel-only vs full hosted-AI retirement), and explicit risks. It also records that this is not release-blocking — the unified panel is already the default surface (#216) and the Familiar coven-stream is hidden by default (#213), so physical deletion is cosmetic and should be its own dogfood-backed effort.
No code changed;
mainis untouched.Linked Issue
Corrects the plan added in #215. Roadmap: design #204; 2a #205, 2b #209, 2c #210, 2d stage-1 #213, retire-cli_chat #214, default-unified #216.
Testing
./script/check_ai_attribution+./script/check_rebrandpass.Agent Mode