fix(ios): flush coalesced chunks on transport errors#3459
Closed
romgenie wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by #3460, which carries the same commits but targets |
Member
Author
|
Closing in favor of #3460 because this PR's non-main base does not trigger repository CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #3455.
Flushes the shared
StreamCoalescerbefore recovering a failed send stream and on each failed/no-resumable resume path, so chunks received during the final coalescing interval are not lost. Updates the mobile native source-contract assertions accordingly.Validation:
pnpm typecheckpnpm check:tests-wiredpnpm test:mobile(81 files)The original head branch is owned by
OpenCovenand does not permit maintainer edits, so this must merge intocody/perf-stream-coalescebefore #3455 can pass its mobile check.