Skip to content

fix: remember workspace surface preferences#3585

Merged
CompleteDotTech merged 9 commits into
mainfrom
agent/surface-preferences-3584
Jul 21, 2026
Merged

fix: remember workspace surface preferences#3585
CompleteDotTech merged 9 commits into
mainfrom
agent/surface-preferences-3584

Conversation

@CompleteDotTech

@CompleteDotTech CompleteDotTech commented Jul 20, 2026

Copy link
Copy Markdown
Member

Closes #3584

Summary

  • add a versioned, typed Workspace preference registry mounted above remounting surfaces
  • migrate durable controls across GitHub, Tasks, Schedules/Calendar, Familiars/Memory, Marketplace, Grimoire, and Browser; retain and bridge existing Grimoire open-tab storage
  • preserve explicit deep-link destinations, migrate legacy keys, clear stale GitHub scope/selection safely, and leave search/modal state transient
  • add registry round-trip/migration/normalization/source-wiring coverage and register it with the app suite

Deep-link and stale-value behavior

Explicit navigation targets win for the current visit without replacing the saved preference. Saved GitHub organization, repository, and selected semantic target are checked against fresh data and only an invalid field is cleared.

Non-goals

This does not restore search text, dialogs, popovers, drawers, confirmation or destructive flows, toasts, undo state, busy/error state, or temporary selection modes.

Verification

  • pnpm exec tsc --noEmit --pretty false
  • pnpm check:tests-wired
  • targeted registry, GitHub, Board, Calendar, Familiars, Browser, and Schedules source-contract tests
  • CI typecheck passed on the prior exact head; the latest exact-head CI is running

Environment note

pnpm lint:design cannot run in this isolated worktree because it has no local node_modules (eslint: not found).

@CompleteDotTech
CompleteDotTech force-pushed the agent/surface-preferences-3584 branch 6 times, most recently from bf76596 to c9d457d Compare July 20, 2026 17:18
@CompleteDotTech
CompleteDotTech force-pushed the agent/surface-preferences-3584 branch from c9d457d to 08018ed Compare July 20, 2026 17:22
@CompleteDotTech
CompleteDotTech marked this pull request as ready for review July 21, 2026 01:34
@CompleteDotTech
CompleteDotTech merged commit b13cce8 into main Jul 21, 2026
15 checks passed
@CompleteDotTech
CompleteDotTech deleted the agent/surface-preferences-3584 branch July 21, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remember durable workspace preferences when revisiting a surface

1 participant