docs: Phase 6 go/no-go decision — keep the process boundary (no source merge)#155
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds an ADR documenting the Phase 6 go/no-go decision for coven CLI unification: do not merge coven-code engine source into the coven binary, and keep the process boundary. This fits the repo’s unification documentation trail by closing out the last open architectural question without introducing code changes.
Changes:
- Add a Phase 6 decision record (ADR) stating NO-GO on a single linked
covenbinary. - Document rationale (licensing, upstream merge channel, migration cost vs. user benefit) plus explicit flip-criteria for revisiting later.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12 tasks
BunsDev
added a commit
that referenced
this pull request
Jul 15, 2026
…164) Close out the coven CLI unification paperwork now that every phase has landed: - unification.md: status complete; phase table rows 5 and 6 finalized (Phase 5 landed via #154/#158/#160 with the npm deprecation executed and npm-publish made opt-in in #162; Phase 6 decided NO-GO via #155); npm-package note rewritten in past tense. - superpowers plans: COMPLETE status banners on the master plan and the phase 3/4/5 sub-plans pointing at docs/unification.md as the living summary; phase 5 task 5.3 marked done (coven-side version_line landed) and task 5.6 recorded as executed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the final decision of the coven CLI unification: Phase 6 go/no-go on merging the engine source into the
covenbinary — decided NO-GO (keep the process boundary). Docs-only.Phases 0–5 delivered a single user-facing
covenCLI drivingcoven-codeas a managed engine process. Phase 6 is a decision, not code: should we go further to a single linked binary?Decision: NO-GO — keep the process boundary
Rationale (full detail in the doc):
covenis MIT,coven-codeis GPL-3.0 (inherited from upstream Claurst). Linking theclaurst-*crates in makes the combined binary GPL; there's no "link but stay MIT," and relicensing needs upstream consent.claurst-*names exist to keepgit merge upstream/mainlow-friction; a source merge throws that away.~/.covenstate, one session ledger + search, one doctor/--version, one brand all already ship without crossing the license line.The doc also records measurable flip-criteria (revisit only if all three hold) and a migration sketch if ever taken — the process-boundary design keeps that door open at zero ongoing cost.
No code changes.