Skip to content

fix(hero): stack feature grid to one column on phones#24

Merged
BunsDev merged 1 commit into
mainfrom
fix/mobile-hero-overflow
Jul 5, 2026
Merged

fix(hero): stack feature grid to one column on phones#24
BunsDev merged 1 commit into
mainfrom
fix/mobile-hero-overflow

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 5, 2026

Copy link
Copy Markdown
Member

Follow-up to the hero swap (#23). Fixes the mobile feature-grid clipping I flagged there.

The bug

At ≤520px the 2×2 feature grid clipped the right column's descriptions — the cells' side padding (14px each) + gaps pushed two columns past ~390px, and .feature-grid's overflow: hidden cut the text at the viewport edge (e.g. "Multiple agents, one shared runtime." and "Open, inspectable, yours to extend." rendered truncated).

The fix

Drop .feature-grid to a single column at ≤520px so cells are full-width and descriptions wrap cleanly on any phone. The compact 2×2 layout is retained for the 521–640px range where it still fits. One-line change (+comment).

Verified with true-mobile screenshots (--headless=new, dpr=2)

  • 390px: clean single column, both previously-clipped descriptions now render in full ✅
  • 560px: still 2×2, no clipping ✅

Note on process: my initial DOM measurement said the grid fit — but it was measuring at an inflated viewport (~465px, not 390). The --headless=new screenshot at true 390px showed the real clip. Trusted the screenshot, confirmed the fix against it.

At <=520px the 2x2 feature grid clipped the right column's descriptions —
the cells' side padding (14px each) plus gaps pushed two columns past ~390px,
and .feature-grid's overflow:hidden cut the text ('one shared runtime.',
'yours to extend.') at the viewport edge.

Drop to a single column at the <=520px breakpoint so cells are full-width and
descriptions wrap cleanly on any phone. The 2x2 layout is retained for the
521-640px range where it still fits.

Verified with true-mobile screenshots (headless=new, dpr=2): 390px shows a clean
single column with full descriptions; 560px keeps 2x2 with no clipping.
Copilot AI review requested due to automatic review settings July 5, 2026 01:06
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
coven Ready Ready Preview Jul 5, 2026 1:06am
coven-landing Ready Ready Preview Jul 5, 2026 1:06am

@BunsDev
BunsDev merged commit 18c209d into main Jul 5, 2026
3 checks passed
@BunsDev
BunsDev deleted the fix/mobile-hero-overflow branch July 5, 2026 01:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the hero section’s responsive CSS to prevent the feature grid’s right column descriptions from being clipped on very small phone widths by switching the grid to a single column at ≤520px.

Changes:

  • Change .feature-grid to a single-column layout under @media (max-width: 520px) to avoid text clipping.
  • Add an explanatory comment documenting the underlying sizing/overflow cause.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/styles/global.css
Comment on lines +928 to 929
.feature-grid { grid-template-columns: 1fr; }
.proof-grid { grid-template-columns: 1fr 1fr; }
BunsDev added a commit that referenced this pull request Jul 5, 2026
…trip below (#25)

Reworks the hero so it fits within a single viewport (no scroll) on standard
laptop heights, and swaps the two requested elements:

- Copy + the platform-aware DownloadCTA now sit together on the LEFT.
- The interactive 'coven cli' runtime card moves to the RIGHT.
- The 4 core-capability cells are pulled OUT of the copy column into a slim
  full-width strip beneath the two-column main row (.hero-main), so neither
  column grows tall enough to force scrolling.

Height work:
- .hero is a centered flex column capped at calc(100vh - 72px) with tightened
  vertical rhythm (smaller headline clamp, trimmed margins/padding).
- Hero collapses from ~1240px to ~640px: fits at 1440x900, 1366x768, and
  1280x720 (verified, ~30px breathing room below the strip at the tight case).

DownloadCTA tidy:
- Button labels shortened (macOS / Windows / Linux / iOS Beta) to keep the row
  a stable single line; kept the 'All releases & checksums' utility link.
- Dropped the redundant 'install the CLI' affordance — the coven cli card in the
  hero already demos the CLI — and removed the now-dead CSS/const/icon.
- Detected platform is emphasized in place (violet) instead of being moved and
  spanned full-width, so the download row's height is deterministic.

Mobile preserved: copy leads, CLI card below, feature grid stacks (2-col at
<=900px, single column at <=520px per #24). No horizontal overflow (body keeps
overflow-x:hidden; flex children min-width:0). Verified content fits with no
right-edge clipping.

Retitles/replaces the earlier column-mirror attempt (#23) with the intended
element swap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants