Skip to content

fix(architecture): gate glossary hover-preview to hover-capable machines #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Jul 7, 2026
Merged

fix(architecture): gate glossary hover-preview to hover-capable machines #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/components/Architecture.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,12 @@ function markKeywords(text: string): string {

let pinnedMark = null;

// Hover-preview is only wired on machines that actually support hovering
// with a fine pointer (mouse/trackpad). Touch devices report (hover: none)
// and would otherwise fire a synthetic mouseenter flash right before the
// tap-to-pin — there, tap and keyboard focus remain the way in.
const canHover = window.matchMedia('(hover: hover) and (pointer: fine)').matches;

function positionTooltip(mark) {
// Measure off-screen so width/height are known, then clamp to the
// viewport. position:fixed keeps the math simple on mobile.
Expand Down Expand Up @@ -376,9 +382,12 @@ function markKeywords(text: string): string {
container.querySelectorAll('.kw').forEach((kw) => {
// Tap/click toggles a pinned, dismissible popover (works on touch).
kw.addEventListener('click', (e) => { e.stopPropagation(); toggleTooltip(kw); });
// Hover/focus preview on pointer devices, but never fight a pin.
kw.addEventListener('mouseenter', () => { if (!pinnedMark) showTooltip(kw, false); });
kw.addEventListener('mouseleave', () => { if (!pinnedMark) hideTooltip(); });
// Hover preview only on machines that support hover; never fight a pin.
if (canHover) {
kw.addEventListener('mouseenter', () => { if (!pinnedMark) showTooltip(kw, false); });
kw.addEventListener('mouseleave', () => { if (!pinnedMark) hideTooltip(); });
}
// Keyboard focus preview stays on every device (desktop tab, AT).
kw.addEventListener('focus', () => { if (!pinnedMark) showTooltip(kw, false); });
kw.addEventListener('blur', () => { if (!pinnedMark) hideTooltip(); });
});
Expand Down