Convert typography from px to rem for zoom accessibility#41
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the landing site’s typography to use rem instead of px for font-size, improving accessibility by allowing text to scale with users’ default font settings while keeping non-typographic layout dimensions in px.
Changes:
- Converted
font-sizevalues frompxtoremacross global styles and key Astro components/pages (includingclamp()endpoints). - Extended the conversion to
Compare.astro(previously excluded). - Updated responsive typography overrides (media queries) to match the new
remsizing.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/styles/global.css | Converts global typography to rem (including clamp() endpoints) and updates responsive font sizing. |
| src/pages/terms.astro | Converts terms page typography font-size values to rem. |
| src/pages/privacy.astro | Converts privacy page typography font-size values to rem (including table text). |
| src/components/Testimonial.astro | Converts trust strip typography font-size values to rem, including a mobile override. |
| src/components/HowItWorks.astro | Converts rail label/status typography font-size values to rem. |
| src/components/Compare.astro | Converts compare UI typography font-size values to rem throughout headings, pills, and details. |
| src/components/Architecture.astro | Converts architecture diagram/tooltip typography font-size values to rem, including responsive tooltip sizing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
765
to
768
| font-family: var(--mono); | ||
| font-size: 9.5px; font-weight: 600; | ||
| font-size: 0.59375rem; font-weight: 600; | ||
| line-height: 14px; | ||
| letter-spacing: 0.14em; text-transform: uppercase; |
Browser font-size preferences now scale all type (values verified identical at 16px root). Structural dimensions stay px. Fresh pass off current main covering all sections, including Compare.astro which was skipped in the original in-flight conversion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BunsDev
force-pushed
the
chore/rem-typography
branch
from
July 9, 2026 06:30
8688d35 to
7f7edbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh re-application of the px→rem typography conversion (originally
ec467c7on the now-deletedfeat/section-overhaul-comparestack, which never landed via PRs #32–#36).font-sizepx values to rem (÷16), including insideclamp()— vw midpoints preservedCompare.astro, which the original commit intentionally skipped while the compare redesign was in flightpnpm build+npm run checkpass