test: allow for Windows PowerShell cold start (deflake #407)#413
Closed
BunsDev wants to merge 1 commit into
Closed
test: allow for Windows PowerShell cold start (deflake #407)#413BunsDev wants to merge 1 commit into
BunsDev wants to merge 1 commit into
Conversation
PowerShell can take several seconds to cold-start on a loaded Windows runner; the 2s activity deadline in codex_json_batch_shim_uses_stdin_and_emits_assistant_text killed the shim before args.txt existed (os error 2). The test exercises stdin and JSONL framing, not the activity deadline, so give startup 10s headroom. Cherry-picked verbatim from PR #402 (48a0e41) so the deflake lands independently of that PR's remaining review items. Fixes #407 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Deflakes a Windows-only PTY runner test by increasing the activity deadline to accommodate intermittent PowerShell cold-start delays on windows-latest, without changing production timeout behavior.
Changes:
- Increase the
stream_codex_json_with_timeoutactivity deadline from 2s to 10s in the Windows-only testcodex_json_batch_shim_uses_stdin_and_emits_assistant_text. - Add an in-test comment documenting the rationale (PowerShell cold start; test is validating stdin + JSONL framing rather than deadline behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407.
codex_json_batch_shim_uses_stdin_and_emits_assistant_textflaked twice on windows-latest (PR #384 run 29398604398, PR #406 run 29589644625) withos error 2: the fake-codex batch shim invokes PowerShell, which can take several seconds to cold-start on a loaded runner — the test's 2s activity deadline killed the child beforeargs.txtwas written. The test exercises stdin transport and JSONL framing, not the activity deadline, so the fix raises the deadline to 10s with a comment.This is @romgenie's fix, cherry-picked verbatim from PR #402 (48a0e41) with authorship preserved, so the deflake lands independently of that PR's remaining review items (it will dedupe cleanly when #402 rebases/merges).
Testing
cargo fmt --check✓,cargo clippy -p coven-cli --all-targets -- -D warnings✓cargo test -p coven-cli pty_runner::✓ (23/23 on unix; the changed test is#[cfg(windows)]— windows-latest CI on this PR is the authoritative check)