Skip to content

test: copy shim stdin with findstr instead of PowerShell (deflake #407) #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Jul 18, 2026
Merged

test: copy shim stdin with findstr instead of PowerShell (deflake #407) #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions crates/coven-cli/src/pty_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3511,11 +3511,15 @@ exit 0
fn codex_json_batch_shim_uses_stdin_and_emits_assistant_text() -> anyhow::Result<()> {
let temp_dir = tempfile::tempdir()?;
let batch = temp_dir.path().join("fake-codex.cmd");
// Copy stdin with findstr (a native, always-present binary with no
// cold start): PowerShell's multi-second startup on loaded runners
// outlived even a 10s activity deadline and flaked this test twice
// (issue #407).
std::fs::write(
&batch,
concat!(
"@echo off\r\n",
"\"%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe\" -NoProfile -Command \"$inputStream=[Console]::OpenStandardInput(); $outputStream=[IO.File]::Open('stdin.txt',[IO.FileMode]::Create); $inputStream.CopyTo($outputStream); $outputStream.Dispose()\"\r\n",
"\"%SystemRoot%\\System32\\findstr.exe\" \"^\" > stdin.txt\r\n",
"echo %* > args.txt\r\n",
Comment on lines 3519 to 3523
"echo {\"type\":\"thread.started\",\"thread_id\":\"thread-456\"}\r\n",
"echo {\"type\":\"item.completed\",\"item\":{\"id\":\"item-1\",\"type\":\"agent_message\",\"text\":\"reply from Codex\"}}\r\n",
Expand All @@ -3536,9 +3540,9 @@ exit 0
};
let mut assistant = Vec::new();

// PowerShell can take several seconds to cold-start on a loaded
// Windows runner. This test exercises stdin and JSONL framing, not the
// activity deadline, so leave enough headroom for process startup.
// Generous headroom for shim process startup on a loaded Windows
// runner (issue #407). This test exercises stdin and JSONL framing,
// not the activity deadline.
let outcome = stream_codex_json_with_timeout(&command, Duration::from_secs(10), |text| {
assistant.push(text.to_string());
Ok(())
Expand Down
4 changes: 3 additions & 1 deletion crates/coven-cli/tests/stream_json_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,9 @@ description = "Windows Codex regression fixture"
&fake_codex,
concat!(
"@echo off\r\n",
"\"%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe\" -NoProfile -Command \"$inputStream=[Console]::OpenStandardInput(); $outputStream=[IO.File]::Open('stdin.txt',[IO.FileMode]::Create); $inputStream.CopyTo($outputStream); $outputStream.Dispose()\"\r\n",
// findstr copies stdin without PowerShell's multi-second cold
// start, which flaked the sibling pty_runner test (issue #407).
"\"%SystemRoot%\\System32\\findstr.exe\" \"^\" > stdin.txt\r\n",
"echo %* > args.txt\r\n",
Comment on lines 514 to 518
"echo {\"type\":\"thread.started\",\"thread_id\":\"thread-789\"}\r\n",
"echo {\"type\":\"turn.started\"}\r\n",
Expand Down