fix: update ChatGPT Codex model hints#317
Merged
Sun-sunshine06 merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review mode: initial
Findings
- [Minor] Missing changeset for user-visible changes — The PR updates the Codex model hint list (user-facing model picker order and default model) and modifies i18n descriptions across four locales. Project conventions require a changeset for user-visible changes. Without one, the changelog will not reflect this update and version bump automation may miss it.
Suggested fix: Runpnpm changesetand commit the resulting markdown file with a message likechore: add changeset for Codex model hint update.
Summary
The PR correctly updates the ChatGPT Codex model hints to promote gpt-5.5 as the default, removes stale gpt-5.1* and gpt-5.2-codex entries, and updates the migration logic to refresh the provider entry and active model if needed. All four locale files are updated consistently. Test coverage is expanded appropriately to verify the new model list and migration behavior. No security, regression, or license issues found. The only missing piece is a changeset to track the user-visible change.
Open-CoDesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt-5.5.gpt-5.1*andgpt-5.2-codexoptions from the static picker list.chatgpt-codexprovider entries on boot, resetting obsolete active models togpt-5.5.gpt-5.5.Verification
pnpm --filter @open-codesign/desktop test -- codex-oauth-ipc.test.tspnpm --filter @open-codesign/desktop test -- ModelSwitcher.test.tspnpm --filter @open-codesign/desktop typecheckpnpm --filter @open-codesign/i18n testpnpm exec biome check apps/desktop/src/main/codex-oauth-ipc.ts apps/desktop/src/main/codex-oauth-ipc.test.ts packages/i18n/src/locales/en.json packages/i18n/src/locales/zh-CN.json packages/i18n/src/locales/es.json packages/i18n/src/locales/pt-BR.jsonNote: full local
pnpm lintis currently blocked by an unrelated untrackedissues_summary.jsonformatting issue in this checkout; the touched files pass Biome.