Skip to content

docs(delivery): review instruction-file changes at tier M - #301

Merged
helebest merged 1 commit into
mainfrom
docs/tier-m-instruction-files
Oct 6, 2026
Merged

helebest merged 1 commit into
mainfrom
docs/tier-m-instruction-files

Conversation

@helebest

@helebest helebest commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves instruction-file changes (CLAUDE.md, .claude/skills/**, .claude/rules/**) from review tier S to tier M in the delivery skill: they change agent behavior, so they get codex (≤ 3 rounds) + /code-review. Plain docs outside src/ stay at tier S.

Why: reviewers of the CLAUDE.md split found earlier instruction-file PRs where codex or fresh-review caught real errors (dikw-core #183/#187, dikw-web #116/#142), and hosted Codex raised P1 findings on the skills in that split (#300). Decided by the maintainer after that evidence.

Delivery receipt

Tier: M (this PR changes .claude/skills/**).

| 4 | review | done | codex (1 round); /code-review |

  • Frontmatter YAML of every skill and rule parses.
  • tools/check_doc_refs.py: OK.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated review-tier guidance to classify CLAUDE.md and .claude/** instruction files as tier M, with the Codex and /code-review process retained.

CLAUDE.md, .claude/skills/**, and .claude/rules/** change agent
behavior, so they now get codex (<= 3 rounds) + /code-review instead of
/code-review only. Plain docs outside src/ stay at tier S.

Evidence: earlier instruction-file PRs where codex or fresh-review caught
real errors (dikw-core #183/#187, dikw-web #116/#142), and the P1
findings hosted Codex raised on the skills in the recent CLAUDE.md split.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T23:38:56.236192Z 10cb2c0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e387a98a-24f5-41e4-aa0a-acc0cfd03589
📥 Commits

Reviewing files that changed from the base of the PR and between c53b668 and 10cb2c0.

📒 Files selected for processing (1)
  • .claude/skills/dikw-core-delivery-workflow/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The review-tier rules no longer include .claude/** in tier S. Tier M now includes CLAUDE.md and .claude/** instruction files and retains the Codex plus /code-review process.

Changes

Review-tier routing

Layer / File(s) Summary
Instruction-file tier rules
.claude/skills/dikw-core-delivery-workflow/SKILL.md
Tier S no longer includes .claude/**. Tier M explicitly includes CLAUDE.md and .claude/** and retains the Codex plus /code-review process.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 10cb2

The change routes instruction-file edits through the stronger review process. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and the move of instruction-file changes to review tier M.
Description check ✅ Passed The description explains the motivation and change, and reports review and validation results. It does not include the template’s Notes / breaking changes section or use its test-plan checkboxes, but …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@helebest

helebest commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@helebest
helebest merged commit 2efd824 into main Oct 6, 2026
10 checks passed
@helebest
helebest deleted the docs/tier-m-instruction-files branch October 6, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant