Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because a request is being made and processed each time a selection is checked or unchecked, I would expect that it can occasionally take awhile for the map to rerender with the newly selected or unselected options. This happened to me yesterday with a slow internet connection. It occurred to me that a slow connection might also happen for someone driving in a car trying to find parking. To denote to the user that their selections (or unselections) have been processed, I added a loader to the screen to denote that the map is reloading. Pictures are included below. It works in Chrome, Firefox, Safari and Edge.
I've also made the legend a bit more transparent to allow the user to see if parking maps are beneath it.