Skip to content

Conversation

@kurtjd
Copy link
Contributor

@kurtjd kurtjd commented Feb 9, 2026

Adds mock sensor and fan to thermal service and updates the thermal std example to make use of them (which simplifies the example quite a lot).

Example can be tested with cargo run --release --bin thermal.

Resolves #619.

@kurtjd kurtjd self-assigned this Feb 9, 2026
@kurtjd kurtjd requested a review from a team as a code owner February 9, 2026 23:32
@kurtjd kurtjd added the enhancement New feature or request label Feb 9, 2026
@kurtjd kurtjd moved this to In review in Embedded Controller Feb 9, 2026
Copy link
Contributor

@jerrysxie jerrysxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, for future expansion, we can consider adding data modeling to the mock so the mock can take a data model to generate different test cases.

@kurtjd kurtjd merged commit f212195 into OpenDevicePartnership:v0.2.0 Feb 10, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Embedded Controller Feb 10, 2026
@tullom
Copy link
Contributor

tullom commented Feb 10, 2026

Good start, for future expansion, we can consider adding data modeling to the mock so the mock can take a data model to generate different test cases.

I've been thinking of a trait that can encapsulate this type of behaviour and also allow for easy fuzz testing. Will create an issue for this. Created #712 to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants