Skip to content

Update Databus id #266 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ludee merged 4 commits into from
Feb 26, 2025
Merged

Update Databus id #266 #267

Ludee merged 4 commits into from
Feb 26, 2025

Conversation

@Ludee
Copy link
Member

@Ludee Ludee commented Feb 26, 2025 •
edited
Loading

Summary of the discussion

Update the id to @id and improve.

Type of change (CHANGELOG.md)

Changed

  • Update dataset id to @id (#267)

Workflow checklist

Automation

Closes #266

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added type: bug 🐛 Something isn't working priority: critical 🔥 Critical priority part: backend 🧱 Backend component status: completed ✔️ Task has been completed labels Feb 26, 2025
@Ludee Ludee self-assigned this Feb 26, 2025
@Ludee Ludee requested a review from jh-RLI February 26, 2025 13:52
@Ludee Ludee marked this pull request as ready for review February 26, 2025 13:52
jh-RLI
jh-RLI approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@Ludee Ludee merged commit 6a8f3e1 into develop Feb 26, 2025
3 checks passed
@Ludee Ludee deleted the bug-266-id branch February 26, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@Ludee Ludee

Labels

part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: completed ✔️ Task has been completed type: bug 🐛 Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The data set key id should be named @id to be used by the Databus

3 participants

@Ludee @jh-RLI