-
Notifications
You must be signed in to change notification settings - Fork 27
Modernize linting setup and add pre-commit checks in CI #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…e-584-enhance-code-linting
- Consolidate linting with ruff, replaces black and extents linting - Additional file checks (case-conflict, docstring-first, mixed-line-ending) - Configure global excludes for build artifacts and cache directories - Enable ruff docstring checking with numpy convention
Ensures consistent checking locally and on GH
|
I remember that @nesnoj expects a larger diff when linting the whole repo. We used black until now - will there be such a large difference in the codebase between ruff and black linting? |
Yes, definitely! Black only covers some aspects of code quality. Furthermore, in this case ruff is configured quite extensively. |
Summary of the discussion
This PR modernizes the linting and code quality setup for the project using ruff. It also establishes automated pre-commit checks in CI (new workflow:
.github/workflows/pre-commit.yml) to ensure consistent code quality across all contributions.pip install -e .[dev]) and committing something or runpre-commit run --all-filespostprocessing/andopen_mastr/soap_api/are excluded from the tests as they will be removed soon so there's no need to bother about the code quality right now.Workflow checklist
Automation
Closes #584
PR-Assignee
Reviewer