Step events aren't appearing realtime on canvas #4326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4326 +/- ##
==========================================
- Coverage 89.37% 89.28% -0.10%
==========================================
Files 425 425
Lines 19940 19940
==========================================
- Hits 17821 17803 -18
- Misses 2119 2137 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replaces manual field mapping with a reusable toStep() helper to reduce code duplication and improve type safety when converting step-like objects (StepDetail, RunDetail.steps) to the Step type used in the cache. Also adds missing TypeScript interface definitions for test helper methods introduced in the race condition fix.
theroinaochieng
approved these changes
Jan 21, 2026
lmac-1
requested changes
Jan 21, 2026
Collaborator
lmac-1
left a comment
lmac-1
left a comment
There was a problem hiding this comment.
Haven't looked too much at the code yet but I'm not seeing this working as expected:
https://www.loom.com/share/88e0eab1345e4f60a457577fbca49e0d
- Success formatting at the end sometimes not coming through
- Result of each step doesn't seem to be streaming in
Collaborator
Author
|
Aaah, good catch @lmac-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that steps in a workflow are highlighted in realtime as the steps are updated
Closes #4261
Validation steps
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)