fix(asus-shutdown): exit cleanly on SIGTERM#143
Open
scardracs wants to merge 1 commit into
Open
Conversation
When asus-shutdown receives a SIGTERM outside of system shutdown (e.g. during manual service management or package update restarts), it ignored the signal and looped indefinitely waiting for logind's PrepareForShutdown signal. Combined with SendSIGKILL=no in the systemd service file, this caused commands like systemctl stop/restart asus-shutdown to hang indefinitely. This patch makes asus-shutdown break the select loop and exit cleanly upon receiving SIGTERM. Since settings application is run synchronously within the event branch, SIGTERM will not interrupt an ongoing GPU firmware write. Closes: OpenGamingCollective#140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When asus-shutdown receives a SIGTERM outside of system shutdown (e.g. during manual service management or package update restarts), it ignored the signal and looped indefinitely waiting for logind's PrepareForShutdown signal. Combined with SendSIGKILL=no in the systemd service file, this caused commands like systemctl stop/restart asus-shutdown to hang indefinitely.
This patch makes asus-shutdown break the select loop and exit cleanly upon receiving SIGTERM. Since settings application is run synchronously within the event branch, SIGTERM will not interrupt an ongoing GPU firmware write.
Closes: #140
Signed-off-by: Marco Scardovi scardracs@disroot.org