Repository navigation
Server browser filters - #452
Conversation
…ing, game types and a search The server browser and the local network's list get a Filters page (FILTERS in the footer, the left trigger, L on the keyboard; or Settings > Online > SERVER BROWSER FILTERS): SHOW FULL GAMES, SHOW EMPTY GAMES and SHOW PASSWORD GAMES (YES or NO), PING (ANY, or under 300, 250, 150, 100 or 50 ms), SEARCH (words a game's server name or map must have, in any case), and GAME TYPES, each of CTF, Slayer, Oddball, King of the Hill and Race shown or hidden, so any mix of them can be listed. The page is a page of Settings' (tools/port_settings.py's BROWSER_FILTERS, under the PC version's FILTERS title), so its OK keeps the choices in config.toml, the network.browser_* settings, and the browser reads them as it opens. Join by Link's list, whose games are the invites taken, is not filtered. A game whose ping is not known (a local network game, a dedicated server the masters list, one still being timed) stays listed under a ping limit. Co-op games have no game type and stay listed (the CO-OP tab is theirs). The counts over the list say how many games the filters hide, and a list they leave empty says so and where to change them. The counts line is wider for it. The full and empty filters, and their settings' names (network.browser_show_full, network.browser_show_empty), follow OpenCE's Filters screen (OpenCommunityEdition#490, by MrBruh), which our port of that change left out with its browser. The left trigger had no key in the menus: L presses it now, and the prompts draw it as L (ui_widget_port_menu_key). The README's paragraph on OpenCE's Filters screen, which this browser never had, is replaced by ours. Checked: the harness's browser_menu test has a filters case (each filter, the settings read, the list's order and hidden count) with negative controls, and the menu_keys test the L key. Co-authored-by: MrBruh <4706866+cybersecurity@users.noreply.github.com>
… keys test name the left trigger (#452)
|
Thanks @cybersecurity: the full and empty filters here, and their setting names, follow the Filters screen in your OpenCommunityEdition#490. |
|
@erincena Thanks for adding this, however I feel the map/server search could be improved. I should have been more specific but I think a better implementation would be to have a separate search for both map and server name but this option should not be under filters. Instead I feel a better place for it would be a blue magnifying glass icon next to each heading: This search should also allow for LIVE, partial matching. So if I type 'b', it should bring all maps with b in the name, then if I ad and L it should then update in realtime with all maps containing bl, then if I continue typing 'bloodgulch' all maps with that in the title should be returned, again updating in realtime as each letter is added. Same with the server name search. Ideally you would click the magnifying glass icon and it would turn into a blinking cursor and you can start typing right away. There should be an 'X' button to clear the current search string and pressing the Esc key on your keyboard should take the user out of the text search so the blinking cursor reverts back to the magnifying glass, clears the current search string and displays all the servers again while retaining any filters set in the filters menu and the text search on the other column. It should also allow a search to be active for both server name and map name at the same time so I could search for servers hosting map containing the word 'bloodgulch' on servers that have 'halo' in the name. The text searches should also be retained if the user first performs a text search then opens the 'Filters' menu, changes a filter and closes the filter menu to go back into the server list. |

Fixes #442
Adds a Filters page to the server browser and the local network's list. Open it with FILTERS in the footer (the left trigger, or L on the keyboard), or from Settings > Online > SERVER BROWSER FILTERS.
The choices are kept in config.toml (
network.browser_*), like the other settings. The counts above the list say how many games are hidden, and an empty list says the filters hid them. Join by Link isn't filtered.The full and empty filters and their setting names follow OpenCE's Filters screen from OpenCommunityEdition#490, which we left out when we ported that change.
Tests: the browser_menu harness test has a filters case with negative controls, and menu_keys checks the new L key.